-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes issue #98 #142
fixes issue #98 #142
Conversation
✅ Deploy Preview for clnapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@Harshit933 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can add the icon of the app as spleshscreen?
Yes I added the main logo of the repo as splash screen on black background. |
This comment was marked as duplicate.
This comment was marked as duplicate.
@vincenzopalazzo |
it is now showing all checks passed . |
Tested on my mobile. Works good. But one question I have is why can't we just build a splashscreen from scratch? It would reduce the number of dependencies. |
In fact building a splash screen from the scratch will look more beautiful and lovely than this. Here in this we can't even change the layout. If we build from the scratch we will have full freedom to add the image, tag line and animations as well. |
That would be nice but please wait for @vincenzopalazzo's review.
I don't have it. |
Sure 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My review is not addressed, you find the icon of the application inside the icon directory of the applications
e.g: the android device has a icon directory
Closing because look inactive |
Pull Request Title
feat(clnapp): fixes issue #98
Description
Added a splash screen in the app using flutter_native_splash. The splash screen now consists of the app logo on a black background.
Checklist
Screenshots (if applicable)
spplashScreen.mp4
Commits
feat(clnapp): fixes issue #98