Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes issue #98 #142

Conversation

Ashurajput02
Copy link

@Ashurajput02 Ashurajput02 commented Feb 18, 2024

Pull Request Title

feat(clnapp): fixes issue #98

Description

Added a splash screen in the app using flutter_native_splash. The splash screen now consists of the app logo on a black background.

Checklist

  • I have tested my changes
  • I have updated the documentation
  • I have added necessary comments

Screenshots (if applicable)

spplashScreen.mp4

Commits

  • feat(clnapp): fixes issue #98
    • Added a splash screen in the app using flutter_native_splash.
    • The splash screen now consists of the app logo on a black background.

Copy link

netlify bot commented Feb 18, 2024

Deploy Preview for clnapp ready!

Name Link
🔨 Latest commit 2b06e7a
🔍 Latest deploy log https://app.netlify.com/sites/clnapp/deploys/65d1a21fbac90c000889173e
😎 Deploy Preview https://deploy-preview-142--clnapp.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Ashurajput02
Copy link
Author

@Harshit933
greetings sir.
Sir , please go through it

Copy link
Member

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can add the icon of the app as spleshscreen?

@Ashurajput02
Copy link
Author

we can add the icon of the app as spleshscreen?

Yes I added the main logo of the repo as splash screen on black background.
Do you want to add this ⚡ icon instead of this?

@Ashurajput02

This comment was marked as duplicate.

@Ashurajput02
Copy link
Author

@vincenzopalazzo
seems so that the error is basically beacuse I didnt integrated with core-lightning

@Ashurajput02
Copy link
Author

it is now showing all checks passed .
furthermore ,I am setting the project on Linux as well . Let me know if it works , else i will raise the PR again once it runs on my linux
@Harshit933

@Harshit933
Copy link
Collaborator

Tested on my mobile. Works good. But one question I have is why can't we just build a splashscreen from scratch? It would reduce the number of dependencies.

@Ashurajput02
Copy link
Author

Tested on my mobile. Works good. But one question I have is why can't we just build a splashscreen from scratch? It would reduce the number of dependencies.

In fact building a splash screen from the scratch will look more beautiful and lovely than this. Here in this we can't even change the layout. If we build from the scratch we will have full freedom to add the image, tag line and animations as well.
I already have made one. Let me modify a bit and we can merge that one rather than of this.
Between can you please provide me some more clear picture of the logo .

@Harshit933
Copy link
Collaborator

I already have made one. Let me modify a bit and we can merge that one rather than of this.

That would be nice but please wait for @vincenzopalazzo's review.

Between can you please provide me some more clear picture of the logo .

I don't have it.

@Ashurajput02
Copy link
Author

Ashurajput02 commented Feb 25, 2024

I already have made one. Let me modify a bit and we can merge that one rather than of this.

That would be nice but please wait for @vincenzopalazzo's review.

Between can you please provide me some more clear picture of the logo .

I don't have it.

Sure 👍
No worries. This one will also work grt.

Copy link
Member

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My review is not addressed, you find the icon of the application inside the icon directory of the applications

e.g: the android device has a icon directory

flutter_native_splash.yaml Show resolved Hide resolved
@vincenzopalazzo
Copy link
Member

Closing because look inactive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants