Skip to content

Commit

Permalink
Update health.dart (#298)
Browse files Browse the repository at this point in the history
See dart-lang/tools#587 (comment)

---

- [x] I’ve reviewed the contributor guide and applied the relevant
portions to this PR.

<details>
  <summary>Contribution guidelines:</summary><br>

- See our [contributor
guide](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md)
for general expectations for PRs.
- Larger or significant changes should be discussed in an issue before
creating a PR.
- Contributions to our repos should follow the [Dart style
guide](https://dart.dev/guides/language/effective-dart) and use `dart
format`.
- Most changes should add an entry to the changelog and may need to [rev
the pubspec package
version](https://github.com/dart-lang/sdk/blob/main/docs/External-Package-Maintenance.md#making-a-change).
- Changes to packages require [corresponding
tests](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md#Testing).

Note that many Dart repos have a weekly cadence for reviewing PRs -
please allow for some latency before initial review feedback.
</details>
  • Loading branch information
mosuem authored Sep 23, 2024
1 parent 4ba6f15 commit 70521d7
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 1 deletion.
2 changes: 2 additions & 0 deletions pkgs/corpus/lib/api.dart
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,8 @@ class ApiUseCollector extends RecursiveAstVisitor implements SurveyorVisitor {
return;
}

//TODO: fix as soon as enclosingElement3 is on Dart stable
// ignore: deprecated_member_use
var enclosingElement = element.enclosingElement!;

if (enclosingElement.kind == ElementKind.CLASS) {
Expand Down
4 changes: 4 additions & 0 deletions pkgs/firehose/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.9.3

- Do not check Dart SDK in PR Health breaking check.

## 0.9.2

- Improve formatting of the github workflow summary comments so they use less
Expand Down
1 change: 1 addition & 0 deletions pkgs/firehose/lib/src/health/health.dart
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,7 @@ Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automati
...['pub', 'global', 'run'],
'dart_apitool:main',
'diff',
'--no-check-sdk-version',
...['--old', baseRelativePath],
...['--new', relativePath],
...['--report-format', 'json'],
Expand Down
2 changes: 1 addition & 1 deletion pkgs/firehose/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: firehose
description: A tool to automate publishing of Pub packages from GitHub actions.
version: 0.9.2
version: 0.9.3
repository: https://github.com/dart-lang/ecosystem/tree/main/pkgs/firehose

environment:
Expand Down

0 comments on commit 70521d7

Please sign in to comment.