Enhancement/refactor txmanager

[darrenvechain]

PR-Codex overview

This PR focuses on refactoring and enhancing the txmanager and thorgo modules, improving transaction management, and updating various function signatures and implementations for better clarity and functionality.

Detailed summary

• Removed unused files: pk_manager.go, transactions_delegation_test.go, and hash_test.go.
• Updated Apply method in Filter to remove limit validation.
• Introduced Decode method in Transaction for decoding transactions.
• Updated references to NewBuilder in tests to use transactions.NewBuilder.
• Changed client field to Client in Thor struct for consistency.
• Added GasPayer method in Builder to set the gas payer for transactions.
• Implemented DelegatedManager for managing delegated transaction fees.
• Created PKDelegator and URLDelegator for handling fee payments.
• Updated various test cases to reflect changes in method signatures and functionality.
• Enhanced error handling in transaction-related methods for clarity.
• Refactored Client methods to improve consistency and readability.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

Release Notes

• New Features

  • Enhanced README.md with new usage examples for the Thor GO SDK.
  • Introduced a transaction management system allowing delegation of transaction fee payments.
  • Added support for gas payer specification in transaction builders.

• Bug Fixes

  • Improved error handling and assertions in test cases for better clarity and accuracy.

• Documentation

  • Expanded documentation for the Thor GO SDK, improving usability for developers.

• Refactor

  • Consolidated private key management and transaction signing logic.
  • Renamed and updated method signatures for consistency across the SDK.

• Tests

  • Added comprehensive test coverage for new delegation functionalities and updated existing tests to reflect changes in method names and structures.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces several enhancements across multiple files in the Thor GO SDK. Key changes include the addition of new usage examples in the README.md, the introduction of a Contract struct in builtins/contract.go, and modifications to account and transaction management methods in client/client.go. Additionally, the test files have been updated to reflect new naming conventions and functionality, while new transaction delegation features have been added in the txmanager package. Overall, these changes improve documentation, code structure, and testing coverage.

Changes

File	Change Summary
README.md	Added usage examples for creating a client and interacting with a smart contract.
builtins/contract.go	Introduced Contract struct, methods for managing Ethereum contracts, and global contract variables.
client/accounts_test.go	Renamed test functions to use "At" instead of "ForRevision" for consistency.
client/client.go	Changed client field to *http.Client, updated constructor methods, and renamed several account methods.
hash/hash_test.go	Updated benchmarks and tests for hashing functions, added tests for Keccak256.
solo/solo.go	Removed setup function, initialized keys directly in init.
thorgo/accounts/accounts.go	Updated methods to use new naming conventions for account retrieval.
thorgo/accounts/accounts_test.go	Transitioned to accounts_test package, updated variable declarations and method calls.
thorgo/accounts/contract.go	Renamed fields in Contract struct for clarity, updated method signatures.
thorgo/accounts/contract_test.go	Transitioned to accounts_test package, updated variable names for clarity.
thorgo/events/events.go	Removed error check on limit parameter in Apply method.
thorgo/thorgo.go	Changed client field to Client for public access, updated method calls accordingly.
thorgo/thorgo_test.go	Updated assertions in test functions to align with new method names.
thorgo/transactions/transactions_delegation_test.go	Deleted file containing delegation tests.
thorgo/transactions/transactions_test.go	Transitioned to transactions_test package, updated transaction handling logic.
thorgo/transactions/txbuilder.go	Added gasPayer field to Builder struct and related methods.
thorgo/transactions/txbuilder_test.go	Transitioned to transactions_test package, updated transaction builder instantiation.
transaction/transaction.go	Introduced Decode function for deserializing transactions.
txmanager/delegator.go	Introduced delegation management system with DelegatedManager, PKDelegator, and URLDelegator.
txmanager/delegator_test.go	Added tests for delegation functionality.
txmanager/pk_manager.go	Deleted file containing previous PKManager implementation.
txmanager/private_key.go	Introduced new PKManager struct for managing private keys and transaction signing.
txmanager/private_key_test.go	Updated tests to integrate with new PKManager functionality.
txmanager/types.go	Introduced types and interfaces for transaction management and delegation.

Poem

🐇 In the land of code, where changes bloom,
New examples sprout, dispelling the gloom.
Contracts and accounts, all neatly aligned,
With tests that now sparkle, and logic refined.
Hooray for the updates, let’s hop and rejoice,
For every new feature, we cheer and we voice! 🎉

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.