Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue in Data Type Conversion (TIMESTAMP WITH LOCAL TIMEZONE)
Issue:
In version 24.0, the
TIMESTAMP WITH LOCAL TIME ZONE
data type was converting correctly due to specific handling in the code. However, in version 24.3, this data type no longer converts as expected, due to changes in the_sql_type
subroutine inOracle.pm
.Example:
Input:
CREATE TABLE example_table (
id NUMBER PRIMARY KEY,
event_time TIMESTAMP WITH LOCAL TIME ZONE
);
Expected Output:
CREATE TABLE example_table (
id SERIAL PRIMARY KEY,
event_time TIMESTAMP WITH TIMEZONE
);
Converted Output:
CREATE TABLE example_table (
id SERIAL PRIMARY KEY,
event_time TIMESTAMP WITH LOCAL TIMEZONE
);
Solution:
Added a dedicated condition in the sub _sql_type() within
Oracle.pm
to handle this specific data type conversion without affecting other code changes.Line number 2081 to 2092 reflect our changes in oracle.pm