Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling Timestamp Datatype #1835

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

newtora2pg
Copy link
Contributor

Issue in Data Type Conversion (TIMESTAMP WITH LOCAL TIMEZONE)

Issue:
In version 24.0, the TIMESTAMP WITH LOCAL TIME ZONE data type was converting correctly due to specific handling in the code. However, in version 24.3, this data type no longer converts as expected, due to changes in the _sql_type subroutine in Oracle.pm.

Example:

Input:

CREATE TABLE example_table (
id NUMBER PRIMARY KEY,
event_time TIMESTAMP WITH LOCAL TIME ZONE
);

Expected Output:

CREATE TABLE example_table (
id SERIAL PRIMARY KEY,
event_time TIMESTAMP WITH TIMEZONE
);

Converted Output:

CREATE TABLE example_table (
id SERIAL PRIMARY KEY,
event_time TIMESTAMP WITH LOCAL TIMEZONE
);

Solution:
Added a dedicated condition in the sub _sql_type() within Oracle.pm to handle this specific data type conversion without affecting other code changes.
Line number 2081 to 2092 reflect our changes in oracle.pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant