Fix Building Against Newer Version Of FFmpeg #1537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building against a newer version: * Use `ch_layout.order` & `ch_layout.nb_channels` instead of `channel_layout` & `channels`. * Workaround `read_probe` no longer being exposed by calling `av_probe_input_format`
Fortunately, the FFmpeg package in Ubuntu 20.04 also has the `av_probe_input_format` method. Therefore, we can remove the old code.
|
I'm not actually sure if what I pushed is the correct solution, but at least it allows for distros, with a newer version of FFmpeg to successfully build Darling. |
|
I'll let future me deal with any regressions caused by this change. Right now it's more important for Darling to build successfully then it is to have working audio. |
ghpzin
added a commit
to ghpzin/nixpkgs
that referenced
this pull request
Oct 15, 2024
- add patch from upstream commit: darlinghq/darling#1537 darlinghq/darling@9655d55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1525