fix(chore): allow to delete keys by regex #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for teal-sprinkles-4c7f14 canceled.
|
darkweak
requested changes
Jun 22, 2024
|
@HobMartin can you rebase to be sure every tests are ok please? I fixed the Etcd version in the GitHub actions. |
darkweak
approved these changes
Jun 23, 2024
HobMartin
force-pushed
the
fix/chore/purge-keys-by-regex
branch
from
40059a2 to
dccd9d7
Compare
|
Thank you @HobMartin 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After providing some testing of removing keys by regex from Redis storage using Souin API, I saw that keys still exist, and nothing happened after calling the
PURGErequest with regex. But thePURGErequest to the/flushendpoint works.So I debugged the purge method and found that it deleted keys only by providing a whole key ID. So I added checking if the key is the regex than
Deletemethod in Souin API should callDeleteManyinstead ofDelete.Related to #417