-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Ethers Dependencies #117
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still WIP, and needs a lot of cleaning. But opening in case I am doing anything egregiously wrong that hasn't been noted in TODOs to my self. Javascript fool here so want to catch mistakes early. |
nmushegian
added a commit
that referenced
this pull request
May 16, 2022
* rearrange for mock deploys * buildweb * buildweb * clean * finalize * clean * force gh pages build * clean * Create CNAME * gardening * gardening * style * fix command * demo * Move cid (#112) * fix CID utils for lock location move CID utils to app lib uses release pack * update output Co-authored-by: stobiewan <[email protected]> * clean * trace walk * dont overwrite dmap with mock dmap * Remove ethers from main (#118) * use RPC calls in place of ethers in main.js * add address to dmap facade Co-authored-by: stobiewan <[email protected]> * Remove Ethers Dependencies (#117) * very rough utils file; replace BigNumber, toHexString, and hexZeroPad in dmap.js * no typescript; replace BigNumber, toHexString, hexZeroPad * replace keccak256 with base js-sha3 wrapper for strings * remove dependency on ethers abi encoder * homegrown calldata for funcs with bytes32 args; no more ethers for dmap * clean up utils file * consolidate * consolidate * fix tests for combined utils (#119) Co-authored-by: stobiewan <[email protected]> * cut ipfs http client (#120) Co-authored-by: stobiewan <[email protected]> * use infura if no node and no window.ethereum (#121) Co-authored-by: stobiewan <[email protected]> * cut buffer and first half of dependencies (#122) Co-authored-by: stobiewan <[email protected]> * readme * clean walk output * include address in page Co-authored-by: stobiewan <[email protected]> Co-authored-by: stobiewan <[email protected]> Co-authored-by: dmfxyz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the various dependencies on Ethers as reference in #113.
Approach is to create our own utils folder. Single file for now, could split it out more nicely later if needed.
PR very much WIP.
npm run test
currently passing with these changes.To replace:
To make better in replacement
dmap_utils
error paths and handlingdmap_utils
meaningful commentsdmap_utils
tests