remove ebnf and disallow digits in dpath #116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmushegian
reviewed
May 4, 2022
| const runes = path.match(/[:.]/g) | ||
|
|
||
| need(names.length === runes.length && baned === null, `Invalid dpath`) | ||
|
|
There was a problem hiding this comment.
Feel this is unlikely to be correct, what about :a..b or similar
I think ebnf should be one of the last things to try to drop
There was a problem hiding this comment.
An empty name like :a..b is fine because then names.length will not equal runes.length (2 != 3), and it'll be rejected.
Picked off ebnf so dmfxyz can keep looking at ethers
There was a problem hiding this comment.
Good point, it is still hard to convince myself it is correct though, also I think using a grammar is something worth showing, like keeping the dependency intentionally
Will think some more
|
Can you reopen for just disallow numbers #115 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #115
relates to #113