Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code shouldn't be all in header files #21

Open
andrewgopher opened this issue Mar 21, 2021 · 0 comments
Open

Code shouldn't be all in header files #21

andrewgopher opened this issue Mar 21, 2021 · 0 comments

Comments

@andrewgopher
Copy link
Contributor

Generally it's not good practice to put everything in a header file. The point of a header file is to reveal the outline of a another cpp or c file so others can easily contribute without needing to communicate and ask what something is.

Although I'm already beginning to understand your code, it would be appreciated if you refactored and migrated your definitions to a new cpp file.

Thanks,
Andrew

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant