New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid integer overflow UB in basic_json_parser #542

Merged

danielaparker merged 1 commit into danielaparker:master from PragmaTwice:patch-1

Oct 7, 2024

Contributor

PragmaTwice commented Oct 3, 2024

In Kvrocks we faced an integer overflow detected by UBSAN in basic_json_parser.

/home/runner/work/kvrocks/kvrocks/build/_deps/jsoncons-src/include/jsoncons/json_parser.hpp:180:74: runtime error: signed integer overflow: 2147483647 + 2 cannot be represented in type 'int'
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /home/runner/work/kvrocks/kvrocks/build/_deps/jsoncons-src/include/jsoncons/json_parser.hpp:180:74 in

The reason is that we set max_nesting_depth to numeric_limits::max(), so that max_nesting_depth + 2 leads to overflow.

Here I use an equivalent form to eliminate the problem.


          Avoid integer overflow UB in basic_json_parser

5a0ec6e

danielaparker merged commit a500279 into danielaparker:master

57 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet