Track favorites on a per-user basis #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, Diesel aliases `Varchar` to `Text`, and `Blob` to `Binary`: * https://docs.diesel.rs/diesel/sql_types/struct.Text.html * https://docs.diesel.rs/diesel/sql_types/struct.Binary.html
Currently, favorites are tracked at the cipher level. For org-owned ciphers, this means that if one user sets it as a favorite, it automatically becomes a favorite for all other users that the cipher has been shared with.
|
Sounds good to me but we should migrate the favorites for user owned ciphers at least, the favorites for the org ciphers can be ignored as they are probably wrong. |
|
Okay, I think that should be doable. |
jjlin
commented
Aug 23, 2020
| #[cfg(feature = "sqlite")] | ||
| diesel::sql_query("PRAGMA defer_foreign_keys = ON").execute(&connection).expect("Failed to disable Foreign Key Checks during migrations"); | ||
| diesel::sql_query("PRAGMA foreign_keys = OFF").execute(&connection).expect("Failed to disable Foreign Key Checks during migrations"); |
There was a problem hiding this comment.
Note that PRAGMA defer_foreign_keys doesn't work here because it's automatically turned off at the end of a transaction [1], so it's actually only in effect for the first migration.
[1] https://sqlite.org/pragma.html#pragma_defer_foreign_keys
thelittlefireman
pushed a commit
to thelittlefireman/bitwarden_rs
that referenced
this pull request
Mar 19, 2021
Track favorites on a per-user basis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, favorites are tracked at the cipher level. For org-owned ciphers,
this means that if one user sets it as a favorite, it automatically becomes a
favorite for all other users that the cipher has been shared with.
Fixes #885.