Ignores args

[pizcadesaber]

Ignore args and change $method to $target based on 'wire:target' for shared rate limiters.

[danharrin]

Please explain "ignore args" and the changes in this PR

[pizcadesaber]

Rate limits only need the function name, so I used an option to exclude function arguments from the backtrace. This improves performance.

[danharrin]

Please rename $method back to $target as it is a breaking change. Please add the limit: named arguments back.

[pizcadesaber]

I have already renamed the parameters to $method.

But are there intentions to change them? It might be clearer to call it something like target, as it could be used in situations where you want to apply the same rate limit to multiple methods.

[danharrin]

I don't want to change it at the moment since it is a breaking change.

Please put back the named arguments that you removed

[pizcadesaber]

I believe they are already renamed as I mentioned in the second commit. Should I do anything else?

Edit: Now I just realized what you mean. I’ll do it, but I think it’s unnecessary in this case.

[danharrin]

It is a styling choice, it makes it clearer in the code what 2 is.

[danharrin]

Thanks