Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test intensity values for files with and without RGB #27

Merged
merged 13 commits into from
Oct 26, 2024

Conversation

dancergraham
Copy link
Owner

@dancergraham dancergraham commented Oct 19, 2024

Fixes #20

Update tests to verify the correctness of intensity values for files with and without RGB.

  • test_read_intensity: Add assertions to check the range of intensity values.
  • test_no_rgb_intensity: Add a new test function to verify that files without RGB do not return intensity values.

For more details, open the Copilot Workspace session.

Fixes #20

Update tests to verify the correctness of intensity values for files with and without RGB.

* **test_read_intensity**: Add assertions to check the range of intensity values.
* **test_no_rgb_intensity**: Add a new test function to verify that files without RGB do not return intensity values.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/dancergraham/e57-python/issues/20?shareId=XXXX-XXXX-XXXX-XXXX).
@dancergraham dancergraham changed the title Fix intensity values for files with and without RGB Test intensity values for files with and without RGB Oct 19, 2024
@dancergraham
Copy link
Owner Author

I don't understand why this is passing on some platforms and failing on others - it looks as though normalisation has successfully been disabled on Windows and x86 linux but not on aarch64 linux or x86 macos !

@dancergraham dancergraham merged commit 67f984a into main Oct 26, 2024
3 checks passed
@dancergraham dancergraham deleted the fix-intensity-values branch October 26, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test for correct intensity values
1 participant