-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test intensity values for files with and without RGB #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #20 Update tests to verify the correctness of intensity values for files with and without RGB. * **test_read_intensity**: Add assertions to check the range of intensity values. * **test_no_rgb_intensity**: Add a new test function to verify that files without RGB do not return intensity values. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/dancergraham/e57-python/issues/20?shareId=XXXX-XXXX-XXXX-XXXX).
dancergraham
changed the title
Fix intensity values for files with and without RGB
Test intensity values for files with and without RGB
Oct 19, 2024
(cherry picked from commit fd90816)
…o fix-intensity-values
I don't understand why this is passing on some platforms and failing on others - it looks as though normalisation has successfully been disabled on Windows and x86 linux but not on aarch64 linux or x86 macos ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20
Update tests to verify the correctness of intensity values for files with and without RGB.
For more details, open the Copilot Workspace session.