Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable compression on control frames #1042

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Disable compression on control frames #1042

wants to merge 1 commit into from

Commits on Oct 12, 2024

  1. Disable compression on control frames 

    As noted in daltoniam#848, compression should only be applied to data frames.
When compression is applied to control frames, specifically to pong
messages, a correctly implemented server will fail the websocket
connection:

> An endpoint MUST NOT set the "Per-Message Compressed" bit of control
> frames and non-first fragments of a data message.  An endpoint
> receiving such a frame MUST _Fail the WebSocket Connection_.

From the RFC: https://datatracker.ietf.org/doc/html/rfc7692#section-6.1
    @jonstaff
    jonstaff committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    ac1e7ae View commit details
    Browse the repository at this point in the history