-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ed25519: Add wycheproofs #640
Open
pinkforest
wants to merge
7
commits into
dalek-cryptography:main
Choose a base branch
from
pinkforest:wychepoofs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…low separated" This reverts commit ccc338f.
This was referenced Mar 8, 2024
5 tasks
koba-e964
reviewed
Apr 14, 2024
[package] | ||
name = "generate-wycheproofs" | ||
version = "0.1.0" | ||
edition = "2021" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe adding publish = false
may help because the crate looks primarily for testing and not meant to be used by other people.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem by dynamically adding tests at runtime is these can be missed silently if the dyn generation fails - google doesn't add / modify / remove them much in any case so can just re-generate & check em in when needed 🤷♀️
wycheproofs-ed25519-dalek
is excluded from workspace--all-features
so it doesn't barf with theed25519-dalek/legacy_compatibility
-It still gets tested by default features OK via workspace
Notes
Testing whole workspace with
--all-features
enables every feature fromed25519-dalek
dependency despitewycheproofs-ed25519-dalek
not explicitly including it due to how the resolver works within workspace.Namedly
ed25519-dalek/legacy_compatibility
causes barf at wycheproof expanded generated.rs tc 63 and 85 failsrepro @ 4af5275
workspace_root $ cargo test --target x86_64-unknown-linux-gnu --features legacy_compatibility
So tests worked I guess :]
Follow-Ups
I will also send another PR to turn the VALIDATION_CRITERIA into static tests directly from C2SP/CCTV/ed25519/vectors.json and some sort of checksumming / commit following thing perhaps to follow modulo easily