This repository has been archived by the owner on Jan 19, 2019. It is now read-only.
Fixed new events flow, added sponsored field, removed suggestions link from navbar #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexwgraves
suggested changes
Mar 29, 2018
There was a problem hiding this comment.
The CSS looks good!
There are some bugs/issues that need to be resolved though:
- Flow is now messed up in the other direction – if you click
Add Eventfrom the calendar view, it takes you to a separate page. I think you should be able to fix this by checking which page the user is currently on, and changing what it displays based on that. Basically, if the user is coming from/events, it should take them to an entirely separate page. Otherwise, it should display it in the calendar sidebar. - When creating an event from the
/eventspage, successful creation of the event takes you back to/events– it should go to the newly-created event's page. (It looks like it used to do this and you changed it – please change it back to thisformat.html { redirect_to @event, notice: "#{@event.title} was successfully created." }inevents_controller.rb. Sorry if I told you something different before!) - It also displays two success banners (the notice is rendering twice?)
alexwgraves
reviewed
Mar 29, 2018
| @@ -55,7 +54,7 @@ def create | |||
|
|
|||
| respond_to do |format| | |||
| if @event.save | |||
| format.html { redirect_to @event, notice: "#{@event.title} was successfully created." } | |||
| format.html { redirect_to events_url, notice: "#{@event.title} was successfully created." } | |||
There was a problem hiding this comment.
Change this back – they should be taken to the new event when they create it.
alexwgraves
reviewed
Mar 29, 2018
| @@ -48,6 +49,7 @@ | |||
| f.input :recurrence_amt | |||
| f.input :featured | |||
| f.input :featured_snippet | |||
| f.input :sponsored, :toggle | |||
There was a problem hiding this comment.
I think fixing the error for this might be as simple as removing , :toggle from this. If you look at featured, which is also a boolean, it doesn't have the toggle param.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #28: made the New Event page mimic the New Organization page
Closes #109: Added a boolean 'sponsored' to the database and to the event admin file
Closes #91
Removed suggestions link from navbar