Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tikhonov Regularization #98

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

ErickHernandezGutierrez
Copy link
Contributor

No description provided.

@MarioOcampo
Copy link
Contributor

Hello @ErickHernandezGutierrez,
thanks for the PR. Can I ask you to change the line breaks of the files, they should be LF.

CHANGELOG.md Show resolved Hide resolved
commit/core.pyx Outdated Show resolved Hide resolved
commit/core.pyx Outdated Show resolved Hide resolved
commit/core.pyx Outdated Show resolved Hide resolved
commit/core.pyx Outdated Show resolved Hide resolved
commit/core.pyx Outdated Show resolved Hide resolved
commit/operator/operator.pyx Outdated Show resolved Hide resolved
commit/core.pyx Outdated Show resolved Hide resolved
commit/operator/operator_noLUT.c Outdated Show resolved Hide resolved
@@ -185,3 +185,62 @@ void COMMIT_At(
pthread_join( threads[t], NULL );
return;
}

void COMMIT_L(
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why all these functions are empty if no LUT is selected? The regularization should be enforced in any case, no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is in the TODO to enable the Tikhonov regularization when no LUT is selected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants