Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User search bars #853

Merged
merged 14 commits into from
Oct 29, 2024
Merged

User search bars #853

merged 14 commits into from
Oct 29, 2024

Conversation

fabiolalombardim
Copy link
Contributor

@fabiolalombardim fabiolalombardim commented Jun 13, 2024

Closes #851 with following points by @ashutoshpw

  • Fixed Search Logic on Treasury Tokens page
  • Fixed icons in pagination for next and previous page
  • Fixed a Typescript issue
  • Added a button for clear filters

Copy link

netlify bot commented Jun 13, 2024

Deploy Preview for tezos-homebase ready!

Name Link
🔨 Latest commit d650d2d
🔍 Latest deploy log https://app.netlify.com/sites/tezos-homebase/deploys/67157627452f860008d221de
😎 Deploy Preview https://deploy-preview-853--tezos-homebase.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 36 (🔴 down 4 from production)
Accessibility: 89 (no change from production)
Best Practices: 100 (no change from production)
SEO: 54 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@fabiolalombardim fabiolalombardim changed the base branch from develop to user-trxs June 13, 2024 14:51
@fabiolalombardim fabiolalombardim changed the base branch from user-trxs to develop June 13, 2024 15:08
@fabiolalombardim fabiolalombardim changed the base branch from develop to user-trxs June 13, 2024 15:08
@fabiolalombardim fabiolalombardim self-assigned this Jun 14, 2024
Copy link
Collaborator

@Man-Jain Man-Jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somthing wrong with logic, doesn't work when type the whole symbol in search bar and shows empty even though the search term token exists. @ashutoshpw

@ashutoshpw ashutoshpw self-assigned this Oct 1, 2024
- Fixed Search Logic on Treasury Tokens
- Fixed icons in pagination for next and previous page
- Fixed a TS issue
- Added a button for clear filters
@Man-Jain
Copy link
Collaborator

Screenshot 2024-10-21 at 02 34 50 The logic is still not working.

Copy link
Collaborator

@Man-Jain Man-Jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes

@Man-Jain
Copy link
Collaborator

If you go to a specific page on token list page. and then search for token not in that page the search doesn't work or doesn't show the token you're searching for. Even if it's there.

  1. Go to specific page
Screenshot 2024-10-21 at 02 37 41
  1. search for a token that exists.
Screenshot 2024-10-21 at 02 37 51

@ashutoshpw
Copy link
Collaborator

Screenshot 2024-10-21 at 02 34 50 The logic is still not working.

@Man-Jain This item appears in the list because the search considers the id, name, and symbol fields when processing the query. In this case, the name of the PNLP token is ‘SEB-PEPE PNLP’, which is why it shows up in the search results.

@Man-Jain
Copy link
Collaborator

Screenshot 2024-10-21 at 02 34 50 The logic is still not working.

@Man-Jain This item appears in the list because the search considers the id, name, and symbol fields when processing the query. In this case, the name of the PNLP token is ‘SEB-PEPE PNLP’, which is why it shows up in the search results.

Ohhh makes sense then. Alright.

@ashutoshpw
Copy link
Collaborator

#853 (comment)

If you go to a specific page on token list page. and then search for token not in that page the search doesn't work or doesn't show the token you're searching for. Even if it's there.

1. Go to specific page
Screenshot 2024-10-21 at 02 37 41
2. search for a token that exists.
Screenshot 2024-10-21 at 02 37 51

@Man-Jain This one is resolved now by resetting the page counter whenever user searches for something.

@EightRice EightRice requested review from EightRice and removed request for Man-Jain October 29, 2024 18:37
@EightRice EightRice merged commit 0bf0e8e into user-trxs Oct 29, 2024
6 checks passed
@EightRice EightRice deleted the user-search-bars branch October 29, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants