Dbp 537 implement autoscaler otc dns handling #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
providers/telekom.go
Outdated
| // Creation of a new OTC DNS record | ||
| // Deletion of a existing OTC DNS record | ||
| // Updating of the IP in a OTC DNS record | ||
| package providers |
There was a problem hiding this comment.
The structure isn't right, Telekom doesn't implement the Provider interface, so it shouldn't be in the providers package, we should create a separate interface and package for DNS providers.
There was a problem hiding this comment.
Moved the telekom related code into the package "telekom_providers"
|
The structure isn't quite right, the code should be in a dns_providers package next to the providers package to allow us to support other DNS providers |
simoncolincap
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Links to Tickets or other PRs
Notes
Approval for review