Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rhombic & deltoidal #60

Merged
merged 9 commits into from
Jun 10, 2024
Merged

rhombic & deltoidal #60

merged 9 commits into from
Jun 10, 2024

Conversation

Fil
Copy link
Member

@Fil Fil commented Jun 9, 2024

local copy of #59 ;

closes #57
closes #39

deltoidal hexecontahedral

deltoidalHexecontahedral

rhombic dodecahedral

rhombicDodecahedral

@Fil
Copy link
Member Author

Fil commented Jun 9, 2024

@rbathoorn this integrates your code, with a few tweaks:

  • changed the base tooling to be more modern (we now have unit tests running in CI!)
  • the new projections are listed in the README
  • edited the default angle, scale, translate parameters so that the maps would fit in the usual 960x500 frame
  • modified the default rotate
  • tweaked the implementation to more modern JavaScript

I wonder if we could shorten the names of the two new projections. The complete (& accurate) geometric description is a bit long.

The default aspect of the rhombic dodecahedral might need some more thought. It would be more readable with the North pole at the top?

Note that because of the new rhombic dodecahedral projection, the previously "geoDodecahedral" projection should be “pentagonal dodecahedral" :) But I don't plan to change its symbol.

Another remark is that the polyhedral/ sub-directory is now a bit inconsistent… maybe we should flatten everything since most of these projections are polyhedral?

@Fil Fil mentioned this pull request Jun 9, 2024
2 tasks
@Fil Fil changed the title rhombic rhombic & deltoidal Jun 9, 2024
src/rhombic.js Outdated Show resolved Hide resolved
@Fil Fil mentioned this pull request Jun 10, 2024
@Fil
Copy link
Member Author

Fil commented Jun 10, 2024

This feels like a better default aspect:

d3.geoRhombicDodecahedral().rotate([80, 0, -Math.asin(Math.sqrt(3) / 3) * 90])

rhombic

@bathoorn
Copy link

This feels like a better default aspect:

d3.geoRhombicDodecahedral().rotate([80, 0, -Math.asin(Math.sqrt(3) / 3) * 90])

Look better indeed. And the names of the functions could be shortened to something like geoRhombic and geoDeltoidal I just put in the whole names as all the previous ones also had the complete names :)

@Fil Fil merged commit c4d721f into main Jun 10, 2024
1 check passed
@Fil Fil deleted the fil/rhombic branch June 10, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

deltoidal hexecontahedron projection clipping bug
3 participants