fix: the handlers should be changing user provided input (#35)

d2iq-labs · Apr 9, 2024 · 0e91d4d · 0e91d4d
1 parent cb8fadb
commit 0e91d4d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 9 deletions.
diff --git a/pkg/handlers/nutanix/mutation/prismcentralendpoint/inject.go b/pkg/handlers/nutanix/mutation/prismcentralendpoint/inject.go
@@ -120,13 +120,8 @@ func (h *nutanixPrismCentralEndpoint) Mutate(
 					Kind: credentials.NutanixTrustBundleKindString,
 					Data: string(decoded),
 				}
-			}
-
-			// Always force insecure to false if additional trust bundle is provided.
-			// This ensures that the trust bundle is actually used to validate the connection.
-			if additionalTrustBundle != "" && prismCentral.Insecure {
-				log.Info("AdditionalTrustBundle is provided, setting insecure to false")
-				prismCentral.Insecure = false
+				// TODO: Consider always setting Insecure to false when AdditionalTrustBundle is set.
+				// But do it in a webhook and not hidden in this handler.
 			}
 
 			obj.Spec.Template.Spec.PrismCentral = prismCentral

diff --git a/pkg/handlers/nutanix/mutation/prismcentralendpoint/inject_test.go b/pkg/handlers/nutanix/mutation/prismcentralendpoint/inject_test.go
@@ -102,8 +102,8 @@ var _ = Describe("Generate Nutanix Prism Central Endpoint patches", func() {
 							gomega.BeEquivalentTo("prism-central.nutanix.com"),
 						),
 						gomega.HaveKeyWithValue("port", gomega.BeEquivalentTo(9441)),
-						// Assert the insecure field was set to false as the additional trust bundle is set
-						gomega.HaveKeyWithValue("insecure", false),
+						// Assert the insecure field was not modified when additional trust bundle is set.
+						gomega.HaveKeyWithValue("insecure", true),
 						gomega.HaveKey("credentialRef"),
 						gomega.HaveKey("additionalTrustBundle"),
 					),