Skip to content

Commit

Permalink
Merge pull request #154 from czbiohub-sf/153-issues-when-running-yogo…
Browse files Browse the repository at this point in the history
…-test

153 issues when running yogo test
  • Loading branch information
paul-lebel authored Jun 17, 2024
2 parents cef8673 + a5cda91 commit be9dc41
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions yogo/model.py
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,7 @@ def from_pth(
return model, {
"step": global_step,
"class_names": class_names,
"normalize_images": params["normalize_images"],

This comment has been minimized.

Copy link
@Axel-Jacobsen

Axel-Jacobsen Jun 19, 2024

Collaborator

Howdy! back from vacation, sorry for being MIA most of the week.

This was the previous behavior. One thing I don't really like about how I implemented YOGO was having the (model, config) tuple returned from YOGO.from_pth method. I guess I missed a couple spots.

@paul-lebel @i-jey mind if I open a PR reverting this line and fixing the other locations of normalize_images?

}

def to(self, device, *args, **kwargs):
Expand Down
2 changes: 1 addition & 1 deletion yogo/utils/test_model.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ def test_model(args: argparse.Namespace) -> None:
"slurm-job-id": os.getenv("SLURM_JOB_ID", default=None),
}

log_to_wandb = args.wandb or len(args.wandb_resume_id) > 0
log_to_wandb = args.wandb or (args.wandb_resume_id is not None)

if log_to_wandb:
print("logging to wandb")
Expand Down

0 comments on commit be9dc41

Please sign in to comment.