-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(build): fix optional poetry dependencies #338
Conversation
6ad242c
to
385dce7
Compare
Codecov Report
@@ Coverage Diff @@
## main #338 +/- ##
=======================================
Coverage 95.40% 95.40%
=======================================
Files 56 56
Lines 3134 3134
=======================================
Hits 2990 2990
Misses 144 144
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Self-reviewed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! I left a couple of comments and overall felt this looked good. I seek your input on the codecov.yml
file changes specifically to make sure this is ready before an approval from me. Please don't hesitate to let me know if you have any questions.
Optional pip dependencies were configured incorrectly and were always being installed. The dependencies have been reconfigured as optional and included in the expected "extras" groups. Fixes cytomining#335
385dce7
to
542307d
Compare
Description
Optional pip dependencies were configured incorrectly and were always being installed. The dependencies have been reconfigured as optional and included in the expected "extras" groups.
Fixes #335
What is the nature of your change?
Checklist
Please ensure that all boxes are checked before indicating that a pull request is ready for review.
📚 Documentation preview 📚: https://pycytominer--338.org.readthedocs.build/en/338/