-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop bmc-log-collector #1432
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takara9
force-pushed
the
bmc-log-collector3
branch
2 times, most recently
from
September 25, 2024 08:31
4b18979
to
7942d1f
Compare
takara9
force-pushed
the
bmc-log-collector3
branch
from
September 26, 2024 05:51
6870436
to
92220f7
Compare
takara9
force-pushed
the
bmc-log-collector3
branch
3 times, most recently
from
September 27, 2024 07:51
05f7746
to
82a8413
Compare
masa213f
requested changes
Sep 27, 2024
takara9
force-pushed
the
bmc-log-collector3
branch
from
September 30, 2024 08:51
ec84eb7
to
308fd5a
Compare
takara9
force-pushed
the
bmc-log-collector3
branch
from
October 1, 2024 00:20
d154110
to
95a27b5
Compare
masa213f
requested changes
Oct 1, 2024
bmc-log-collector/log-collector.go
Outdated
// In that case, determine if the log has already been | ||
// issued based on the time it was generated. | ||
if lastPtr.LastReadTime < createUnixtime { | ||
bmcByteJsonLog, _ := json.Marshal(members.Sel[i]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not fixed.
sorry, sure fixed.
takara9
force-pushed
the
bmc-log-collector3
branch
from
October 1, 2024 07:38
ceaa895
to
c5d634c
Compare
change machineslist from serverlist migrate from bmc-log-collector2 update docs update for review comment update fix error update fix bug define version Remove userFile from selCollector update based on checklist update for review comment update by dctest delete redundant code update prevent file lost update wrong add fsync system call
takara9
force-pushed
the
bmc-log-collector3
branch
from
October 1, 2024 09:10
e5b1af2
to
9b492df
Compare
masa213f
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.