Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop bmc-log-collector #1432

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Develop bmc-log-collector #1432

merged 1 commit into from
Oct 2, 2024

Conversation

takara9
Copy link
Contributor

@takara9 takara9 commented Sep 18, 2024

No description provided.

@takara9 takara9 self-assigned this Sep 18, 2024
@takara9 takara9 marked this pull request as draft September 18, 2024 08:58
@takara9 takara9 marked this pull request as ready for review September 19, 2024 08:04
@takara9 takara9 force-pushed the bmc-log-collector3 branch 2 times, most recently from 4b18979 to 7942d1f Compare September 25, 2024 08:31
@takara9 takara9 marked this pull request as draft September 26, 2024 04:52
@takara9 takara9 marked this pull request as ready for review September 26, 2024 05:52
@takara9 takara9 force-pushed the bmc-log-collector3 branch 3 times, most recently from 05f7746 to 82a8413 Compare September 27, 2024 07:51
bmc-log-collector/bmc-user.go Outdated Show resolved Hide resolved
bmc-log-collector/LICENSE Outdated Show resolved Hide resolved
bmc-log-collector/Makefile Outdated Show resolved Hide resolved
bmc-log-collector/main.go Outdated Show resolved Hide resolved
bmc-log-collector/main.go Outdated Show resolved Hide resolved
bmc-log-collector/log-pointer.go Outdated Show resolved Hide resolved
bmc-log-collector/log-pointer.go Outdated Show resolved Hide resolved
bmc-log-collector/log-pointer.go Outdated Show resolved Hide resolved
bmc-log-collector/main.go Outdated Show resolved Hide resolved
bmc-log-collector/log-pointer.go Outdated Show resolved Hide resolved
bmc-log-collector/Makefile Outdated Show resolved Hide resolved
// In that case, determine if the log has already been
// issued based on the time it was generated.
if lastPtr.LastReadTime < createUnixtime {
bmcByteJsonLog, _ := json.Marshal(members.Sel[i])
Copy link
Contributor

@masa213f masa213f Oct 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not fixed.

sorry, sure fixed.

change machineslist from serverlist

migrate from bmc-log-collector2

update docs

update for review comment

update fix error

update fix bug

define version

Remove userFile from selCollector

update based on checklist

update for review comment

update by dctest

delete redundant code

update prevent file lost

update wrong

add fsync system call
Copy link
Contributor

@masa213f masa213f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@takara9 takara9 merged commit 9804251 into main Oct 2, 2024
97 checks passed
@takara9 takara9 deleted the bmc-log-collector3 branch October 2, 2024 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants