Develop bmc-log-collector and update machines-endpoints #1420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delete unnecessary coment update TAG and go version
takara9
force-pushed
the
bmc-log-collector2
branch
from
dfb2af3
to
3c34c54
Compare
masa213f
requested changes
Sep 11, 2024
|
|
||
| ## Usage | ||
|
|
||
| *** under writing *** |
Comment on lines
+98
to
+100
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
There are three blank lines. Is this intentional?
Comment on lines
+110
to
+112
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
There are three blank lines. Is this intentional?
zoetrope
reviewed
Sep 11, 2024
zoetrope
reviewed
Sep 11, 2024
zoetrope
reviewed
Sep 11, 2024
zoetrope
reviewed
Sep 11, 2024
zoetrope
reviewed
Sep 11, 2024
zoetrope
reviewed
Sep 11, 2024
zoetrope
reviewed
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreate PR based on #1361, #1389