Regular Update 2023/07 #1060
Merged
Regular Update 2023/07 #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yamatcha
force-pushed
the
update-monitoring-container-202307
branch
3 times, most recently
from
0e7895d
to
d40a276
Compare
yamatcha
force-pushed
the
update-monitoring-container-202307
branch
from
26da02c
to
c2a2507
Compare
yamatcha
force-pushed
the
update-monitoring-container-202307
branch
from
c2a2507
to
6ec0c99
Compare
| @@ -13,7 +13,7 @@ WORKDIR /go/src/github.com/jimmidyson/configmap-reload | |||
| RUN curl -fsSL -o configmap-reload.tar.gz "https://github.com/jimmidyson/configmap-reload/archive/v${CONFIGMAP_RELOAD_VERSION}.tar.gz" \ | |||
| && tar -x -z --strip-components 1 -f configmap-reload.tar.gz \ | |||
| && rm -f configmap-reload.tar.gz \ | |||
| && CGO_ENABLED=0 go install -ldflags="-w -s" ./ | |||
| && CGO_ENABLED=0 go install --installsuffix cgo -ldflags="-w -s -extldflags '-static'" ./ | |||
There was a problem hiding this comment.
This modification is not required on recent golang but I don't request change because the original Makefile is written so.
umezawatakeshi
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.