Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ended and invited flags #31

Merged
merged 2 commits into from
Nov 2, 2017
Merged

Conversation

zagreusinoz
Copy link
Contributor

This addresses part of #7. I needed these flags for a project of mine. I will try to remember to go back and do the others in that issue when my current project is done.

@zagreusinoz
Copy link
Contributor Author

The PHP5.6 build failed due to laravel no longer supporting it I guess.

@antonkomarev
Copy link
Member

antonkomarev commented Nov 1, 2017

@zagreusinoz thank you for contribution!

This happens because phpunit requires PHP >= 7.0 .
I accept adding of .idea directory to .gitignore rules but I'd recommend you to add it to global gitignore on your own machine. Because different IDEs uses different temporary directories, and each developer should care about own development environment.

Will be able to check and merge it today evening.

@antonkomarev antonkomarev merged commit 489c8bc into cybercog:master Nov 2, 2017
@antonkomarev
Copy link
Member

antonkomarev commented Nov 2, 2017

@zagreusinoz code merged. I've added you to Contributors in README.
Travis tests fixed too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants