Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interfaces to contract files and Jupyter Labs demo #18

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

zcor
Copy link

@zcor zcor commented Feb 26, 2021

No description provided.

@zcor
Copy link
Author

zcor commented Feb 26, 2021

When you have leisure time, I've posted the draft pull request here #18

The only questions I had was the convention for where to store Vyper interfaces — from researching it looked like it was most common to keep these in the contract file (they handled struct datatypes better this way too), but I can break these out easily into a separate file or multiple files if preferred.

It was also not clear how Vyper interfaces are best meant to handle function polymorphism (overloading of functions), so I only included the version of the functions with the most arguments (ie without optional parameters).

@michwill
Copy link
Contributor

Uhm... I think, Vyper folks usually have no problem with interfaces - I meant .sol ones.

Apparently @iamdefinitelyahuman has a tool to autogenerate those https://github.com/iamdefinitelyahuman/abi2solc though, so just the matter of properly communicating it to devs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants