Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new alert colors #597

Merged
merged 8 commits into from
Jan 17, 2025
Merged

feat: new alert colors #597

merged 8 commits into from
Jan 17, 2025

Conversation

DanielSchiavini
Copy link
Contributor

  • Update alert colors based on the new design
  • Note that the alignment is different than in the design. The text is aligned with the title
  • The inverted colors had to be saved per theme variant, we cannot mix themes

@vercel Vercel
Copy link

vercel bot commented Jan 14, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
curve-dapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 9:09am
curve-dapp-crvusd ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 9:09am
curve-dapp-dao ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 9:09am
curve-dapp-lend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 9:09am
curve-dapp-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 9:09am

@0xAlunara 0xAlunara mentioned this pull request Jan 14, 2025
Closed
0xtutti
0xtutti previously approved these changes Jan 14, 2025
View reviewed changes
OnlyJousting
OnlyJousting previously approved these changes Jan 14, 2025
View reviewed changes
0xAlunara
0xAlunara requested changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@0xAlunara 0xAlunara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smol incorrect icon name but I won't let it block the PR (you already got 2 approvals anyway)

packages/curve-ui-kit/src/shared/icons/ExclamationTriangleIcon.tsx Outdated Show resolved Hide resolved
@DanielSchiavini DanielSchiavini dismissed stale reviews from OnlyJousting and 0xtutti via a251392 January 15, 2025 11:39
@DanielSchiavini
Copy link
Contributor Author

image

@DanielSchiavini DanielSchiavini merged commit 7331e49 into main Jan 17, 2025
11 checks passed
@DanielSchiavini DanielSchiavini deleted the fix/feedback-colors branch January 17, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xtutti 0xtutti 0xtutti approved these changes

@OnlyJousting OnlyJousting OnlyJousting approved these changes

@0xAlunara 0xAlunara 0xAlunara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DanielSchiavini @0xAlunara @OnlyJousting @0xtutti