Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide legacy category from scope visualizer in fully migrated languages #2727

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

AndreasArvidsson
Copy link
Member

@AndreasArvidsson AndreasArvidsson commented Jan 14, 2025

When using the scope visualizer for a language that is fully migrated to our scope handlers I thought it was unnecessary that we showed an empty legacy category in the scope visualizer.

Checklist

  • [/] I have added tests
  • [/] I have updated the docs and cheatsheet
  • [/] I have not broken the cheatsheet

@AndreasArvidsson AndreasArvidsson requested a review from a team as a code owner January 14, 2025 06:49
@AndreasArvidsson AndreasArvidsson changed the title Hide legacy scope from scope visualizer in fully migrated languages Hide legacy category from scope visualizer in fully migrated languages Jan 14, 2025
Copy link
Member

@phillco phillco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo! A good problem to have

@phillco phillco added this pull request to the merge queue Jan 14, 2025
Merged via the queue into main with commit a7d3488 Jan 14, 2025
15 checks passed
@phillco phillco deleted the scopeVisualizerLegacy branch January 14, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants