Tweak condition showing "No credentials" alert to account for V2 #1632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anahkiasen
requested review from
LucWollants,
JonasVHG,
brampauwelyn,
simon-debruijn,
vhande,
grubolsch and
dev-publiq
as code owners
LucWollants
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
This will make the check indeed more reliable, but the main issue with this integration https://platform.publiq.be/admin/resources/integrations/e0f53aa5-c59e-405d-9948-138b37a8c62f is the missing v1 keys.
To get some feedback about failed key creation this ticket was created https://jira.publiq.be/browse/PPF-659
simon-debruijn
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
Since the condition below uses that to pick which clients to render, and the condition for the alert only checked legacy clients, this seems to be the correct fix but it could be the things are more complicated than that? For example not sure if I should also check
keyVisibilityUpgradeTicket: https://jira.publiq.be/browse/PPF-640