Remove projectRepository from ImportProjectController

cultuurnet · Nov 24, 2023 · 0935c5e · 0935c5e
1 parent f669002
commit 0935c5e
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 35 deletions.
diff --git a/app/Project/ProjectControllerProvider.php b/app/Project/ProjectControllerProvider.php
@@ -29,10 +29,7 @@ public function connect(Application $app)
         };
 
         $app['import_project_controller'] = function (Application $app) {
-            return new ImportProjectController(
-                $app['command_bus'],
-                $app['project_repository']
-            );
+            return new ImportProjectController($app['command_bus']);
         };
 
         $app['open_project_controller'] = function (Application $app) {

diff --git a/src/Project/Controller/ImportProjectController.php b/src/Project/Controller/ImportProjectController.php
@@ -3,9 +3,8 @@
 namespace CultuurNet\ProjectAanvraag\Project\Controller;
 
 use CultuurNet\ProjectAanvraag\Project\Command\ImportProject;
-use Doctrine\ORM\EntityRepository;
-use GuzzleHttp\Psr7\Response;
 use SimpleBus\Message\Bus\Middleware\MessageBusSupportingMiddleware;
+use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Component\HttpFoundation\Request;
 
 class ImportProjectController
@@ -17,18 +16,12 @@ class ImportProjectController
      */
     private $commandBus;
 
-    /**
-     * @var EntityRepository
-     */
-    protected $projectRepository;
-
-    public function __construct(MessageBusSupportingMiddleware $commandBus, EntityRepository $projectRepository)
+    public function __construct(MessageBusSupportingMiddleware $commandBus)
     {
         $this->commandBus = $commandBus;
-        $this->projectRepository = $projectRepository;
     }
 
-    public function importProject(string $uuid, Request $request): Response
+    public function importProject(string $uuid, Request $request): JsonResponse
     {
         $postedProject = json_decode($request->getContent());
 
@@ -49,6 +42,6 @@ public function importProject(string $uuid, Request $request): Response
             )
         );
 
-        return new Response();
+        return new JsonResponse();
     }
 }
diff --git a/test/Project/Controller/ImportProjectControllerTest.php b/test/Project/Controller/ImportProjectControllerTest.php
@@ -2,9 +2,7 @@
 
 namespace CultuurNet\ProjectAanvraag\Project\Controller;
 
-use CultuurNet\ProjectAanvraag\Entity\Project;
 use CultuurNet\ProjectAanvraag\Project\Command\ImportProject;
-use Doctrine\ORM\EntityRepository;
 use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 use SimpleBus\Message\Bus\Middleware\MessageBusSupportingMiddleware;
@@ -23,11 +21,6 @@ class ImportProjectControllerTest extends TestCase
      */
     private $messageBus;
 
-    /**
-     * @var EntityRepository & MockObject
-     */
-    private $projectRepository;
-
     /**
      * @var Request & MockObject
      */
@@ -39,12 +32,7 @@ public function setUp()
 
         $this->request = $this->createMock(Request::class);
 
-        $this->projectRepository = $this->createMock(EntityRepository::class);
-
-        $this->controller = new ImportProjectController(
-            $this->messageBus,
-            $this->projectRepository
-        );
+        $this->controller = new ImportProjectController($this->messageBus);
     }
 
     public function testImportProject()
@@ -79,13 +67,7 @@ public function testImportProject()
             ->method('handle')
             ->with($importProject);
 
-        $this->projectRepository
-            ->expects($this->once())
-            ->method('findOneBy')
-            ->with(['platformUuid' => $platformUuid])
-            ->willReturn((new Project())->setId(123));
-
         $response = $this->controller->importProject($platformUuid, $this->request);
-        $this->assertEquals(new JsonResponse(['databaseId' => 123]), $response, 'It correctly handles the request');
+        $this->assertEquals(new JsonResponse(), $response, 'It correctly handles the request');
     }
 }