Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for python 3.8, declare support for 3.13 #301

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

youtux
Copy link
Contributor

@youtux youtux commented Oct 15, 2024

🤔 What's changed?

  • Dropped support for python 3.8, which is now EOL
  • Declared support for 3.13, which is now stable
  • Update the codebase to remove constructs for python < 3.9

⚡️ What's your motivation?

Keeping the codebase updated.

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)
  • 💥 Breaking change (incompatible changes to the API)

♻️ Anything particular you want feedback on?

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@jsa34
Copy link
Contributor

jsa34 commented Oct 15, 2024

Should we add pyupgrade to the pre-commit yml?

@youtux
Copy link
Contributor Author

youtux commented Oct 15, 2024

Should we add pyupgrade to the pre-commit yml?

Yes, and possibly flake8 too, so that we can see unused imports.
I'll do that in a next PR

@youtux youtux merged commit cefb74e into main Oct 16, 2024
40 checks passed
@youtux youtux deleted the ab/drop-python-3.8 branch October 16, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants