Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Node.js 23 #2446

Merged
merged 4 commits into from
Nov 16, 2024
Merged

Support Node.js 23 #2446

merged 4 commits into from
Nov 16, 2024

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Nov 16, 2024

🤔 What's changed?

This PR adds support for Node.js 23 which is now the "current" version.

It includes some small changes to reflect that doing require() on an ES module can now work so long as the module has no top-level awaits, see also https://nodejs.org/en/blog/release/v23.0.0 and https://nodejs.org/docs/latest/api/modules.html#loading-ecmascript-modules-using-require

🏷️ What kind of change is this?

  • ⚡ New feature (non-breaking change which adds new behaviour)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@coveralls
Copy link

coveralls commented Nov 16, 2024

Coverage Status

coverage: 97.688% (-0.08%) from 97.765%
when pulling 2f5b4cf on node-23
into 03a57a5 on main.

@davidjgoss davidjgoss marked this pull request as ready for review November 16, 2024 11:06
@davidjgoss davidjgoss merged commit 1c4d9c5 into main Nov 16, 2024
10 checks passed
@davidjgoss davidjgoss deleted the node-23 branch November 16, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants