Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): replace strip-ansi with native Node API #2436

Merged
merged 1 commit into from
Oct 5, 2024

Conversation

Namchee
Copy link
Contributor

@Namchee Namchee commented Oct 4, 2024

🤔 What's changed?

This pull request replaces strip-ansi with native Node API stripVTControlCharacters available since Node 16.

⚡️ What's your motivation?

Reducing the amount of unneeded dependencies.

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@coveralls
Copy link

Coverage Status

coverage: 97.838%. remained the same
when pulling 9c7e80e on Namchee:chore/replace-strip-ansi
into d612cc5 on cucumber:main.

Copy link
Contributor

@davidjgoss davidjgoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@davidjgoss davidjgoss merged commit edaf1c0 into cucumber:main Oct 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants