Change the reported url and method #2139
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidjgoss
requested changes
Feb 3, 2023
There was a problem hiding this comment.
Thanks for getting this going @harcop!
Would you be able to:
- Remove the
.tool-versionsfile - Revert changes to the
package-lock.json(looks like you have an older version of npm there) - Remove the
console.logstatements
| const req = httpx.request(url, { | ||
| method, | ||
| headers: allHeaders, | ||
| timeout: 10000, |
There was a problem hiding this comment.
Did adding this solve a problem for you?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Fix the reported url and method
⚡️ What's your motivation?
Fix the misleading error message. If the second http request fails, the error message refers to the first request, this change fixes this so that the second request is used instead.
🏷️ What kind of change is this?
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.