Fix warnings found by lgtm #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request fixes 5 alerts when merging 9d4123f into 4789fbc - view on LGTM.com fixed alerts:
|
Update from master (add config)
|
This pull request fixes 5 alerts when merging 39a451b into d5f2c8f - view on LGTM.com fixed alerts:
|
|
Hmm, interesting. Looks like config didn't got updated, but ok. |
|
This pull request introduces 2 alerts and fixes 12 when merging d0c29c2 into d5f2c8f - view on LGTM.com new alerts:
fixed alerts:
|
|
LGTM is good but sooooooo slow… |
|
This pull request fixes 12 alerts when merging a2b5543 into d5f2c8f - view on LGTM.com fixed alerts:
|
|
This PR is complete and fix all 12 warnings, so I'm merging it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue work on #45. This PR should fix all warnings found by LGTM. Currently work-in-progress.