Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check invalid keepers before reset #795

Merged
merged 3 commits into from
May 11, 2024

Conversation

lilongjiao
Copy link
Contributor

No description provided.

Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 53.86%. Comparing base (830965b) to head (dcaec0a).
Report is 11 commits behind head on master.

❗ Current head dcaec0a differs from pull request most recent head 898dac7. Consider uploading reports for the commit 898dac7 to get more accurate results

Files Patch % Lines
...ons/sentinel/collector/command/ResetSentinels.java 85.71% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #795      +/-   ##
============================================
+ Coverage     53.83%   53.86%   +0.02%     
- Complexity    10440    10455      +15     
============================================
  Files          1794     1794              
  Lines         56347    56390      +43     
  Branches       5899     5905       +6     
============================================
+ Hits          30337    30372      +35     
- Misses        23409    23421      +12     
+ Partials       2601     2597       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lmdyyh lmdyyh merged commit 5beb801 into master May 11, 2024
1 check failed
@lilongjiao lilongjiao deleted the bugfix/check-keeper-role-before-reset branch May 29, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants