Use <file_guid> instead of <file_id> to avoid confusion

cslzchen · Feb 5, 2024 · 060f08e · 060f08e
1 parent 33d73bf
commit 060f08e
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/api/files/serializers.py b/api/files/serializers.py
@@ -402,7 +402,7 @@ class FileSerializer(BaseFileSerializer):
 
     cedar_metadata_records = RelationshipField(
         related_view='files:file-cedar-metadata-records-list',
-        related_view_kwargs={'file_id': 'get_file_guid_or_error'},
+        related_view_kwargs={'file_guid': 'get_file_guid_or_error'},
     )
 
     def get_target_type(self, obj):

diff --git a/api/files/urls.py b/api/files/urls.py
@@ -6,7 +6,7 @@
 
 urlpatterns = [
     re_path(r'^(?P<file_id>\w+)/$', views.FileDetail.as_view(), name=views.FileDetail.view_name),
-    re_path(r'^(?P<file_id>\w+)/cedar_metadata_records/$', views.FileCedarMetadataRecordsList.as_view(), name=views.FileCedarMetadataRecordsList.view_name),
+    re_path(r'^(?P<file_guid>\w+)/cedar_metadata_records/$', views.FileCedarMetadataRecordsList.as_view(), name=views.FileCedarMetadataRecordsList.view_name),
     re_path(r'^(?P<file_id>\w+)/versions/$', views.FileVersionsList.as_view(), name=views.FileVersionsList.view_name),
     re_path(r'^(?P<file_id>\w+)/versions/(?P<version_id>\w+)/$', views.FileVersionDetail.as_view(), name=views.FileVersionDetail.view_name),
 ]
diff --git a/api/files/views.py b/api/files/views.py
@@ -193,7 +193,7 @@ class FileCedarMetadataRecordsList(JSONAPIBaseView, generics.ListAPIView, ListFi
     view_name = 'file-cedar-metadata-records-list'
 
     def get_default_queryset(self):
-        return CedarMetadataRecord.objects.filter(guid___id=self.kwargs['file_id'])
+        return CedarMetadataRecord.objects.filter(guid___id=self.kwargs['file_guid'])
 
     def get_queryset(self):
         return self.get_queryset_from_request()