Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

public links: return error when owner could not be resolved #4907

Merged
merged 2 commits into from
Nov 4, 2024
+6 −0
Merged

public links: return error when owner could not be resolved #4907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
012461a
public links: return error when owner could not be resolved
glpatcern Nov 1, 2024
742d606
changelog
glpatcern Nov 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelog/unreleased/publink-fix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Bugfix: public links: return error when owner could not be resolved

https://github.com/cs3org/reva/pull/4907
3 changes: 3 additions & 0 deletions pkg/auth/manager/publicshares/publicshares.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,9 @@ func (m *manager) Authenticate(ctx context.Context, token, secret string) (*user
if err != nil {
return nil, nil, err
}
if getUserResponse.Status.Code != rpcv1beta1.Code_CODE_OK {
return nil, nil, errtypes.NotFound(getUserResponse.Status.Message)
}

share := publicShareResponse.GetShare()
role := authpb.Role_ROLE_VIEWER
Expand Down
Loading