Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async Postprocessing #3531

Merged
merged 11 commits into from
Dec 14, 2022
Merged

Async Postprocessing #3531

merged 11 commits into from
Dec 14, 2022

Conversation

kobergj
Copy link
Contributor

@kobergj kobergj commented Dec 8, 2022

brings postprocessing to edge

Mainly backports from experimental branch #3029

@update-docs
Copy link

update-docs bot commented Dec 8, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@lgtm-com
Copy link

lgtm-com bot commented Dec 8, 2022

This pull request introduces 3 alerts and fixes 1 when merging 7f55677 into 4b19ae9 - view on LGTM.com

new alerts:

  • 2 for Incorrect conversion between integer types
  • 1 for Uncontrolled data used in path expression

fixed alerts:

  • 1 for Uncontrolled data used in path expression

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

@kobergj kobergj mentioned this pull request Dec 8, 2022
Merged
@lgtm-com
Copy link

lgtm-com bot commented Dec 8, 2022

This pull request introduces 3 alerts and fixes 1 when merging 6a88404 into 4b19ae9 - view on LGTM.com

new alerts:

  • 2 for Incorrect conversion between integer types
  • 1 for Uncontrolled data used in path expression

fixed alerts:

  • 1 for Uncontrolled data used in path expression

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

@lgtm-com
Copy link

lgtm-com bot commented Dec 8, 2022

This pull request introduces 3 alerts and fixes 1 when merging d372a69 into 4b19ae9 - view on LGTM.com

new alerts:

  • 2 for Incorrect conversion between integer types
  • 1 for Uncontrolled data used in path expression

fixed alerts:

  • 1 for Uncontrolled data used in path expression

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

@kobergj kobergj mentioned this pull request Dec 8, 2022
Closed
@lgtm-com
Copy link

lgtm-com bot commented Dec 8, 2022

This pull request introduces 3 alerts and fixes 1 when merging a4825d8 into 4b19ae9 - view on LGTM.com

new alerts:

  • 2 for Incorrect conversion between integer types
  • 1 for Uncontrolled data used in path expression

fixed alerts:

  • 1 for Uncontrolled data used in path expression

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

@kobergj kobergj marked this pull request as ready for review December 8, 2022 15:29
butonic
butonic previously requested changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@butonic butonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the rewrite of Upload in fced7bd got lost.

.golangci.yaml Outdated Show resolved Hide resolved
pkg/storage/utils/decomposedfs/upload.go Show resolved Hide resolved
pkg/storage/utils/decomposedfs/upload.go Show resolved Hide resolved
pkg/storage/utils/decomposedfs/upload.go Show resolved Hide resolved
@kobergj kobergj requested a review from butonic December 9, 2022 10:31
@kobergj kobergj force-pushed the AsyncPostprocessing branch 3 times, most recently from 63eda99 to e524a49 Compare December 9, 2022 13:01
@kobergj
disable 0-byte touches
2d407b6 
Signed-off-by: jkoberg <[email protected]>
@kobergj kobergj mentioned this pull request Dec 12, 2022
Closed
25 tasks
C0rby
C0rby reviewed Dec 12, 2022
View reviewed changes
.golangci.yaml Outdated Show resolved Hide resolved
pkg/storage/utils/decomposedfs/upload.go Outdated Show resolved Hide resolved
@kobergj kobergj requested a review from C0rby December 12, 2022 15:16
aduffeck
aduffeck requested changes Dec 12, 2022
View reviewed changes
pkg/storage/utils/decomposedfs/node/node.go Outdated Show resolved Hide resolved
pkg/storage/utils/decomposedfs/lookup/lookup.go Outdated Show resolved Hide resolved
.golangci.yaml Outdated Show resolved Hide resolved
aduffeck
aduffeck approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@aduffeck aduffeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kobergj kobergj merged commit 47e0591 into cs3org:edge Dec 14, 2022
@kobergj kobergj deleted the AsyncPostprocessing branch December 14, 2022 09:04
@micbar micbar mentioned this pull request May 3, 2023
Closed
89 tasks
@ScharfViktor ScharfViktor mentioned this pull request May 4, 2023
Closed
86 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wkloucek wkloucek wkloucek left review comments

@aduffeck aduffeck aduffeck approved these changes

@labkode labkode Awaiting requested review from labkode labkode is a code owner

@ishank011 ishank011 Awaiting requested review from ishank011

@glpatcern glpatcern Awaiting requested review from glpatcern glpatcern is a code owner

@butonic butonic Awaiting requested review from butonic

@C0rby C0rby Awaiting requested review from C0rby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kobergj @aduffeck @butonic @C0rby @wkloucek