Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added a product property product_name to the app provider info #237

Merged
merged 1 commit into from
Nov 5, 2024
+5 −0
Merged

added a product property product_name to the app provider info #237

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions cs3/app/registry/v1beta1/resources.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,11 @@ message ProviderInfo {
// The action to be displayed to the user on the context menu.
// By default this is "Open with".
string action = 9;
// OPTIONAL.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if already merged, I see this is de facto a breaking change, as you're going to use the product_name to identify the application "type": as such, this field should be REQUIRED.

Incidentally, Reva master does not take decisions based on the type (we just set all language headers for every app), and the CS3 wopiserver only has a few extra properties if the application is "Collabora". Nevertheless the new field makes perfect sense, to not risk inconsistencies with an admin-configurable (and user-display-oriented) field.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. That makes sense. It means that we already had some hidden differences for the different products (collabora, codiMD and so on). Now we are making that official. IMHO we can keep it optional to avoid the breaking change on Reva master.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I prefer to break Reva master now :) (those comments are anyhow advisory - unfortunately - meaning that the compilation goes through). At least to keep the API consistent, where I expect the HTTP app provider endpoint and the WOPI /iop/open one to change as well.

// Specifies the kind of app provider.
// A product property that could be used to handle product-specific differences.
// For example: Collabora, OnlyOffice, Microsoft365 or MicrosoftOfficeOnline
string product_name = 10;
}

// Represents a mime type and its corresponding file extension.
Expand Down