Add godot-coi-serviceworker #93
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3549977.
|
This addon seems really neat. I like having this be full-service in that, if anyone picked it up and was expecting it to work on a static site they can without making changes. But at the same time, I know this is unnecessary for those who know how they're exporting. I think adding it to the README is a great idea. As it gives notice to how to fix the potential issue for those who want it without making it mandatory. I'd rather it not bloat the template since it's much more of an option than a necessity |
|
Closing as this hopefully is going to be handled upstream https://godotengine.org/article/progress-report-web-export-in-4-3/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #90
Using https://github.com/nisovin/godot-coi-serviceworker is pretty nice as it exposes this toggle option in the export preset menu:
As long as I like the addon and its ease of use, I wonder how many people in percentage are going to take advantage of this feature.
I think <25% of Godot users care about HTML5 export.
A fraction of that 25% cares about COI since many deploy to Itch.io or other platforms that allow configuring a suitable setup for Godot 4 HTML exports.
I'm not sure if it's better to:
Feedback is welcome!