Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make COI-serviceworker optional? #90

Open
davcri opened this issue Jan 19, 2024 · 3 comments
Open

Make COI-serviceworker optional? #90

davcri opened this issue Jan 19, 2024 · 3 comments
Assignees

Comments

@davcri
Copy link
Member

davcri commented Jan 19, 2024

This PR #89 fixed the web deploy.
However this configuration should not be the default and should be opt-in: if you are deploying a web game and you can set the appropriate HTTP headers it's better to configure them that way instead of relying on https://github.com/gzuidhof/coi-serviceworker

See also godotengine/godot-proposals#6616

@davcri davcri changed the title Make COI-serviceworker optional Make COI-serviceworker optional? Jan 19, 2024
@SecurityRisk
Copy link
Contributor

I agree with this. Right now, if you run the project from within Godot, you'll get a 404 error in the browser console because this file wasn't added to the project. Making it optional or making it only get applied on GH Pages would be really useful

@davcri davcri self-assigned this Jan 21, 2024
davcri added a commit that referenced this issue Jan 21, 2024
@davcri
Copy link
Member Author

davcri commented Jan 21, 2024

@SecurityRisk I'd like to know your opinion on #93. I left some comments there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants