-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make COI-serviceworker optional? #90
Comments
davcri
changed the title
Make COI-serviceworker optional
Make COI-serviceworker optional?
Jan 19, 2024
I agree with this. Right now, if you run the project from within Godot, you'll get a 404 error in the browser console because this file wasn't added to the project. Making it optional or making it only get applied on GH Pages would be really useful |
@SecurityRisk I'd like to know your opinion on #93. I left some comments there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This PR #89 fixed the web deploy.
However this configuration should not be the default and should be opt-in: if you are deploying a web game and you can set the appropriate HTTP headers it's better to configure them that way instead of relying on https://github.com/gzuidhof/coi-serviceworker
See also godotengine/godot-proposals#6616
The text was updated successfully, but these errors were encountered: