Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt to new hax ordering. #759

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Adapt to new hax ordering. #759

merged 2 commits into from
Jan 23, 2025

Conversation

maximebuyse
Copy link
Contributor

Adapts to cryspen/hax#1247

@maximebuyse maximebuyse requested a review from a team as a code owner January 20, 2025 14:47
@maximebuyse
Copy link
Contributor Author

The interesting change is in serialize.rs where a hax_lib::fstar::before needs to be moved.

@maximebuyse maximebuyse mentioned this pull request Jan 20, 2025
Merged
karthikbhargavan
karthikbhargavan approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@karthikbhargavan karthikbhargavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprisingly few source code changes needed here.
This is a much-needed change for F* stability.

@maximebuyse maximebuyse enabled auto-merge January 23, 2025 14:51
@maximebuyse maximebuyse merged commit a09ba24 into main Jan 23, 2025
56 of 57 checks passed
@maximebuyse maximebuyse deleted the new-hax-ordering branch January 23, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karthikbhargavan karthikbhargavan karthikbhargavan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maximebuyse @karthikbhargavan