ML-DSA: update benchmarks pqclean #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschneider-bensch
previously requested changes
Jan 9, 2025
There was a problem hiding this comment.
Thanks, that makes sense!
The criterion ones are not updated, though. Maybe this is a point where we can decide if we want to keep them? For me, they are still very inconsistent from run to run (large run-to-run diffs in signing, mainly) and for this reason I don't look to them at all, I find. So I would be fine retiring them. But you might get some use out of them still?
|
Good point. I totally forgot about those. I updated them just in case we want to use them again... |
jschneider-bensch
approved these changes
Jan 9, 2025
github-actions
bot
dismissed
jschneider-bensch’s stale review
Review re-requested
|
pq-clean mldsa apparently doesn't build on intel macos 🤷🏻 I'll disable it there. |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the pqclean benchmarks to use ml-dsa rather than dilithium.