Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable macos asan #718

Merged
merged 4 commits into from
Dec 16, 2024
Merged

disable macos asan #718

merged 4 commits into from
Dec 16, 2024

Conversation

franziskuskiefer
Copy link
Member

See #717

@franziskuskiefer franziskuskiefer requested a review from a team as a code owner December 16, 2024 14:33
@jschneider-bensch
Copy link
Collaborator

Why don't we use a specific nightly where we know it still worked until it works again on the most recent nightly?

@franziskuskiefer
Copy link
Member Author

Sure, works too. Feel free to update the PR. We just need to get this in asap to unblock #598 and #710

jschneider-bensch
jschneider-bensch approved these changes Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@jschneider-bensch jschneider-bensch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed it to use nightly-2024-12-14, I believe that still worked.

@jschneider-bensch jschneider-bensch added this pull request to the merge queue Dec 16, 2024
Merged via the queue into main with commit fc934b3 Dec 16, 2024
52 checks passed
@jschneider-bensch jschneider-bensch deleted the franziskus/disable-macos-asan branch December 16, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jschneider-bensch jschneider-bensch jschneider-bensch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@franziskuskiefer @jschneider-bensch