Kyber C extraction #153
Merged
Kyber C extraction #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- int match -> if - enumerate loops -> range loops - drop Debug derive
…into franziskus/c-extraction
…into franziskus/c-extraction
…into franziskus/c-extraction
dconnolly
reviewed
Dec 13, 2023
karthikbhargavan
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies kyber such that it can be extracted to C.
The
kyber-crate.shcan be used to extract and copy the C files to hacl-packages (see cryspen/hacl-packages#442).Main changes
cloopmacro to rewrite all iterators into range loops (this macro does not change the code for F* extraction)unwrap()into amatchwith apanicto work around a Eurydice issueiterinto aninto_iterto work around a Eurydice issue