Fix potentially looping predicate_id. #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximebuyse
force-pushed
the
fix-potentially-looping-predicate-id
branch
from
9b99f23 to
3c4d705
Compare
maximebuyse
force-pushed
the
fix-potentially-looping-predicate-id
branch
from
645cb5c to
94124d2
Compare
W95Psp
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR eliminates field
predicate_idto compute it afterimpl_exprresolution instead.A call to
predicate_idmethod inpath_towas making some looping behavior in some specific conditions. This fixes it by keeping thepredicate_idcomputation for later.This bug appeared in #730 with an attempt to resolve using breadth-first instead of depth-first search (but it wasn't reproduced with the current resolution).
We believe that breadth-first changes the order of candidate paths thus triggering the bug with a path that is not seen in depth-first.