library fix for libcrux ci #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franziskuskiefer
approved these changes
May 7, 2024
|
Merging this instead of #652 |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
W95Psp
added a commit
that referenced
this pull request
May 7, 2024
The https://github.com/hacspec/specs repository contains specifications written in hacspec, mainly at the time of hacspec v1. Since hacspec v1 is deprecated and archived, its library is deprecated as well. The hacspec lib (https://github.com/hacspec/hacspec/tree/master/lib) doesn't typecheck any longer with `num-bigint` version `0.4.5`. The hacspec lib dependents on `num-bigint` version `0.4`, not specifying the minor version. The `specs` repository has no `Cargo.lock`, and thus, from a clean `git clone`, `cargo build` pins `num-bigint` to version `0.4.5`, breaking the hacspec library. This broke #653 recently, and we had the same kind of errors a couple times before in the past. Two options were considered: - remove the tests related to the specs in the CI of hax; - commit a `Cargo.lock`. The choose the first one: we need to update those specifications to hax anyway: this will add motivation to hacspec/specs#13.
The https://github.com/hacspec/specs repository contains specifications written in hacspec, mainly at the time of hacspec v1. Since hacspec v1 is deprecated and archived, its library is deprecated as well. The hacspec lib (https://github.com/hacspec/hacspec/tree/master/lib) doesn't typecheck any longer with `num-bigint` version `0.4.5`. The hacspec lib dependents on `num-bigint` version `0.4`, not specifying the minor version. The `specs` repository has no `Cargo.lock`, and thus, from a clean `git clone`, `cargo build` pins `num-bigint` to version `0.4.5`, breaking the hacspec library. This broke #653 recently, and we had the same kind of errors a couple times before in the past. Two options were considered: - remove the tests related to the specs in the CI of hax; - commit a `Cargo.lock`. The choose the first one: we need to update those specifications to hax anyway: this will add motivation to hacspec/specs#13.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
fix(ci): remove `specs` tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the F* library to reverse the order in which the Index trait is resolved.
This is needed to fix the libcrux CI.